34S - Problem With CLx



#2

Hi,

While debugging a program on the 34S side-by-side with a 15C, I noticed that in the 34S, currently CLx leaves stack lift enabled, which is not the way HP calcs work. In the HP machines, the purpose of disabling stack lift with CLx was so if an erroneous number was entered, CLx would allow entering a replacement value without affecting the stack. For consistency, they kept this behavior the same while running in a program as well.

Hopefully, it makes sense to change this so it works in the 34S like all other RPN machines.

Thanks,
Jake


#3

Agreed.

5 ENTER 6 CLX 8 + should return 13, not 8 as it does now.

Good catch, Jake!


#4

I think this can be done. Thanks for testing.

#5

Definitely a bug, I've got two fixes. One is much cleaner, a tiny bit larger and changers many opcodes. The other is ugly.


- Pauli


#6

And the ugly but smaller fix is applied.


- Pauli


#7

Wow. That was fast. So the CLX + bug is fixed as well as the stack lift issue with PI or a constant?

Very nice!


#8

Hopefully they are both fixed. So are complex constants and complex RCL which were also broken by recent changes.

At least, they will be when we do a new build.


- Pauli


Possibly Related Threads...
Thread Author Replies Views Last Post
  WP 34s : An old problem coming back Miguel Toro 2 214 11-05-2013, 03:00 AM
Last Post: Marcus von Cube, Germany
  WP 34S flashing problem Gerson W. Barbosa 15 437 03-02-2013, 10:18 AM
Last Post: Gerson W. Barbosa
  HP 34S complex # problem Richard Berler 2 140 02-17-2013, 11:01 PM
Last Post: Richard Berler
  [WP34S] Entry? <-CLX Christopher Johnson 3 210 09-14-2012, 01:52 PM
Last Post: Walter B
  WP-34S transfer problem Reth 9 331 06-20-2012, 09:25 PM
Last Post: Reth
  [WP-34s] Key-debouncing problem? Daniel Vollmer 5 233 04-11-2012, 02:47 PM
Last Post: Neil Hamilton (Ottawa)
  [wp 34s] wp 34s picture and scan Jeroen Van Nieuwenhove 2 141 10-27-2011, 09:02 PM
Last Post: Les Wright
  Re: 34s: TVM problem? Dominic Richens 3 166 09-26-2011, 07:58 PM
Last Post: Paul Dale
  WP34S: cpx DROP & CLx ? fhub 17 599 08-04-2011, 05:41 PM
Last Post: Walter B
  34s: TVM problem? Gene Wright 63 1,064 07-30-2011, 09:14 PM
Last Post: Paul Dale

Forum Jump: